Make Service Icons work as enum was wrong (#3148)

make #3078 work as enum was wrong. ![image](https://github.com/woodpecker-ci/woodpecker/assets/24977596/933cf69d-9884-4e29-ac7b-21b58a52b870)
woodpecker-ci · Jan 9, 2024 · 5715bd1 · 5715bd1
1 parent 12df59d
commit 5715bd1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/web/components.d.ts b/web/components.d.ts
@@ -76,6 +76,7 @@ declare module 'vue' {
     InputField: typeof import('./src/components/form/InputField.vue')['default']
     IPhGitlabLogoSimpleFill: typeof import('~icons/ph/gitlab-logo-simple-fill')['default']
     ISimpleIconsGitea: typeof import('~icons/simple-icons/gitea')['default']
+    ISvgSpinners180RingWithBg: typeof import('~icons/svg-spinners/180-ring-with-bg')['default']
     ITeenyiconsGitSolid: typeof import('~icons/teenyicons/git-solid')['default']
     ITeenyiconsRefreshOutline: typeof import('~icons/teenyicons/refresh-outline')['default']
     IVaadinQuestionCircleO: typeof import('~icons/vaadin/question-circle-o')['default']

diff --git a/web/src/components/repo/pipeline/PipelineStepList.vue b/web/src/components/repo/pipeline/PipelineStepList.vue
@@ -109,7 +109,7 @@
               }"
               @click="$emit('update:selected-step-id', step.pid)"
             >
-              <PipelineStatusIcon :service="step.type == StepType.Service" :status="step.state" class="!h-4 !w-4" />
+              <PipelineStatusIcon :service="step.type === StepType.Service" :status="step.state" class="!h-4 !w-4" />
               <span class="truncate">{{ step.name }}</span>
               <PipelineStepDuration :step="step" />
             </button>

diff --git a/web/src/lib/api/types/pipeline.ts b/web/src/lib/api/types/pipeline.ts
@@ -149,9 +149,9 @@ export type PipelineFeed = Pipeline & {
 };
 
 export enum StepType {
-  Clone = 1,
-  Service,
-  Plugin,
-  Commands,
-  Cache,
+  Clone = 'clone',
+  Service = 'service',
+  Plugin = 'plugin',
+  Commands = 'commands',
+  Cache = 'cache',
 }