Skip to content

Commit

Permalink
Remove go versions from .golangci.yml (#2775)
Browse files Browse the repository at this point in the history
1. `linter.lang-version` is deprecated in favor of `run.go`
2. `run.go` defaults to the version in `go.mod` as per
[docs](https://golangci-lint.run/usage/configuration/#run-configuration):

```yaml
  # Define the Go version limit.
  # Mainly related to generics support since go1.18.
  # Default: use Go version from the go.mod file, fallback on the env var `GOVERSION`, fallback on 1.18
  go: '1.19'
```

So in summary, we don't need these versions in the file as long as we
keep the version in go.mod bumped.

Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
  • Loading branch information
silverwind and qwerty287 authored Nov 7, 2023
1 parent 9d5ef11 commit 872fea0
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ linters-settings:
misspell:
locale: US
gofumpt:
lang-version: '1.21'
extra-rules: true
forbidigo:
forbid:
Expand Down Expand Up @@ -37,7 +36,6 @@ linters:

run:
timeout: 5m
go: '1.21'

issues:
exclude-rules:
Expand Down

0 comments on commit 872fea0

Please sign in to comment.