Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

woodpecker-cli exec .woodpecker.yaml: "io: read/write on closed pipe" #1615

Closed
alexmt opened this issue Mar 12, 2023 · 0 comments · Fixed by #1616
Closed

woodpecker-cli exec .woodpecker.yaml: "io: read/write on closed pipe" #1615

alexmt opened this issue Mar 12, 2023 · 0 comments · Fixed by #1616
Labels
bug Something isn't working

Comments

@alexmt
Copy link
Contributor

alexmt commented Mar 12, 2023

Component

cli

Describe the bug

Woodpecker CLI logs the error after each step execution.

Sample pipeline:

pipeline:
  step1:
    image: golang
    commands:
      - echo step1
  step2:
    image: golang
    commands:
      - echo step2

Result:

woodpecker exec .woodpecker.yaml                                                                        (k3d-akuity/akuity-platform)
[step1:L0:0s] + echo step1
[step1:L1:0s] step1
8:04PM ERR process logging failed error="io: read/write on closed pipe" CLI=exec
[step2:L0:0s] + echo step2
[step2:L1:0s] step2
8:04PM ERR process logging failed error="io: read/write on closed pipe" CLI=exec

System Info

woodpecker-cli version 0.15.6


### Additional context

_No response_

### Validations

- [X] Read the [Contributing Guidelines](https://github.com/woodpecker-ci/woodpecker/blob/master/CONTRIBUTING.md).
- [X] Read the [docs](https://woodpecker-ci.org/docs/intro).
- [X] Check that there isn't [already an issue](https://github.com/woodpecker-ci/woodpecker/issues) that reports the same bug to avoid creating a duplicate.
- [X] Checked that the bug isn't fixed in the `next` version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
- [X] Check that this is a concrete bug. For Q&A join our [Discord Chat Server](https://discord.gg/fcMQqSMXJy) or the [Matrix room](https://matrix.to/#/#woodpecker:matrix.org).
@alexmt alexmt added the bug Something isn't working label Mar 12, 2023
@alexmt alexmt mentioned this issue Mar 12, 2023
Merged
lafriks added a commit that referenced this issue Mar 12, 2023
@alexmt @lafriks
fix: docker backend should not close 'engine.Tail' result (#1616)
5e1171d 
Closes #1615

The error described in
#1615 is happening
because `Tail` method of the docker backend closes the instance of
`io.ReadCloser` it returns in `defer` function. As a result anything
that try to read data returned by `Tail` method eventually will attempt
to read from closes reader and get an error:


https://github.com/woodpecker-ci/woodpecker/blob/2171212c5a31bfffc8f882716bdd503c65413eee/pipeline/backend/docker/docker.go#L229

The fix is just don't close returned reader and let the consumer of
`Tail` method do it. Good thing is that `Tail` is used only in one place
and reader is correctly closed:


https://github.com/woodpecker-ci/woodpecker/blob/2171212c5a31bfffc8f882716bdd503c65413eee/pipeline/pipeline.go#L231-L237

Example of `woodpecker exec` output using pipeline from
#1615 with the fix:

```
woodpecker exec .woodpecker.yaml
[step1:L0:0s] + echo step1
[step1:L1:0s] step1
[step2:L0:0s] + echo step2
[step2:L1:0s] step2
```

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
6543 pushed a commit to 6543-forks/woodpecker that referenced this issue Mar 14, 2023
@alexmt @lafriks @6543
fix: docker backend should not close 'engine.Tail' result (woodpecker…
afdd0d7 
…-ci#1616)

Closes woodpecker-ci#1615

The error described in
woodpecker-ci#1615 is happening
because `Tail` method of the docker backend closes the instance of
`io.ReadCloser` it returns in `defer` function. As a result anything
that try to read data returned by `Tail` method eventually will attempt
to read from closes reader and get an error:


https://github.com/woodpecker-ci/woodpecker/blob/2171212c5a31bfffc8f882716bdd503c65413eee/pipeline/backend/docker/docker.go#L229

The fix is just don't close returned reader and let the consumer of
`Tail` method do it. Good thing is that `Tail` is used only in one place
and reader is correctly closed:


https://github.com/woodpecker-ci/woodpecker/blob/2171212c5a31bfffc8f882716bdd503c65413eee/pipeline/pipeline.go#L231-L237

Example of `woodpecker exec` output using pipeline from
woodpecker-ci#1615 with the fix:

```
woodpecker exec .woodpecker.yaml
[step1:L0:0s] + echo step1
[step1:L1:0s] step1
[step2:L0:0s] + echo step2
[step2:L1:0s] step2
```

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
@6543 6543 mentioned this issue Mar 14, 2023
Merged
lafriks added a commit that referenced this issue Mar 14, 2023
@6543 @alexmt @lafriks
fix: docker backend should not close 'engine.Tail' result (#1616) (#1620
d07c66d 
)

Backport #1616

Close #1615

The error described in
#1615 is happening
because `Tail` method of the docker backend closes the instance of
`io.ReadCloser` it returns in `defer` function. As a result anything
that try to read data returned by `Tail` method eventually will attempt
to read from closes reader and get an error:



https://github.com/woodpecker-ci/woodpecker/blob/2171212c5a31bfffc8f882716bdd503c65413eee/pipeline/backend/docker/docker.go#L229

The fix is just don't close returned reader and let the consumer of
`Tail` method do it. Good thing is that `Tail` is used only in one place
and reader is correctly closed:



https://github.com/woodpecker-ci/woodpecker/blob/2171212c5a31bfffc8f882716bdd503c65413eee/pipeline/pipeline.go#L231-L237

Example of `woodpecker exec` output using pipeline from
#1615 with the fix:

```
woodpecker exec .woodpecker.yaml
[step1:L0:0s] + echo step1
[step1:L1:0s] step1
[step2:L0:0s] + echo step2
[step2:L1:0s] step2
```

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: docker backend should not close 'engine.Tail' result alexmt/woodpecker
1 participant
@alexmt