Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect swagger response docs for delete secret endpoint #2118

Closed
5 tasks done
lonix1 opened this issue Aug 5, 2023 · 0 comments · Fixed by #2119
Closed
5 tasks done

Incorrect swagger response docs for delete secret endpoint #2118

lonix1 opened this issue Aug 5, 2023 · 0 comments · Fixed by #2119
Labels
bug Something isn't working documentation docu & docs
Milestone
1.0.1

Comments

@lonix1
Copy link
Contributor

lonix1 commented Aug 5, 2023

Component

other

Describe the bug

The swagger docs for endpoint /swagger/index.html#/Secrets/delete_secrets__secret_ show that a successful response is 200, but I actually receive 204.

System Info

1.0.0
docker

Additional context

PS: it might be a good idea to add a "docs" item to the "Component" dropdown in this issue report? Or maybe a separate github issue template for "docs". Just a small idea for better categorisation.

Validations

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.
@lonix1 lonix1 added the bug Something isn't working label Aug 5, 2023
@qwerty287 qwerty287 added this to the 1.1.0 milestone Aug 5, 2023
@qwerty287 qwerty287 added the documentation docu & docs label Aug 5, 2023
@qwerty287 qwerty287 mentioned this issue Aug 5, 2023
Merged
@qwerty287 qwerty287 modified the milestones: 1.1.0, 1.0.1 Aug 5, 2023
@6543 6543 closed this as completed in #2119 Aug 5, 2023
6543 pushed a commit that referenced this issue Aug 5, 2023
@qwerty287
Fix swagger response code (#2119)
4ad3968 
Closes #2118
6543 pushed a commit to 6543-forks/woodpecker that referenced this issue Aug 5, 2023
@qwerty287 @6543
Fix swagger response code (woodpecker-ci#2119)
f1d0e67 
Closes woodpecker-ci#2118
@6543 6543 mentioned this issue Aug 5, 2023
Merged
lafriks pushed a commit that referenced this issue Aug 6, 2023
@6543 @qwerty287
Fix swagger response code (#2119) (#2121)
666b59d 
Closes #2118
Backport #2119

Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation docu & docs
Projects
None yet
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

Fix swagger response code woodpecker-ci/woodpecker
2 participants
@lonix1 @qwerty287