-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go client expects PipelineQueue to return Activity list, but it returns Feed list #2679
Closed
5 tasks done
Closed
5 tasks done
Labels
bug
Something isn't working
Comments
Activity has these extra fields Owner string `json:"owner"`
Name string `json:"name"`
FullName string `json:"full_name"`
CloneURL string `json:"clone_url,omitempty"` Feed has these extra fields "repo_id": 2,
"id": 266,
"remote": "https://github.com/woodpecker-ci/woodpecker", |
runephilosof-karnovgroup
added a commit
to runephilosof-karnovgroup/woodpecker
that referenced
this issue
Nov 1, 2023
The models had gotten out of sync. Use the same definition to avoid them getting out of sync in the future. Closes woodpecker-ci#2679
runephilosof-karnovgroup
added a commit
to runephilosof-karnovgroup/woodpecker
that referenced
this issue
Nov 1, 2023
The models had gotten out of sync. Use the same definition to avoid them getting out of sync in the future. Closes woodpecker-ci#2679
runephilosof-karnovgroup
added a commit
to runephilosof-karnovgroup/woodpecker
that referenced
this issue
Nov 1, 2023
The models had gotten out of sync. Use the same definition to avoid them getting out of sync in the future. Closes woodpecker-ci#2679
runephilosof-karnovgroup
added a commit
to runephilosof-karnovgroup/woodpecker
that referenced
this issue
Nov 1, 2023
The models had gotten out of sync. Closes woodpecker-ci#2679
qwerty287
pushed a commit
that referenced
this issue
Nov 1, 2023
The models had gotten out of sync. Use the same definition ~to avoid them getting out of sync in the future~. Closes #2679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component
other
Describe the bug
In the Go client PipelineQueue expects an Activity list
woodpecker/woodpecker-go/woodpecker/client.go
Line 254 in c36b1cd
But GetPipelineQueue in the server returns a Feed list
woodpecker/server/store/datastore/feed.go
Line 42 in c36b1cd
Activity and Feed does not match
Activity
woodpecker/woodpecker-go/woodpecker/types.go
Line 143 in c36b1cd
Feed
woodpecker/server/model/feed.go
Line 19 in c36b1cd
Either both server and go client should use the same file as model, or CI should ensure that they stay compatible.
System Info
Additional context
No response
Validations
next
version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]The text was updated successfully, but these errors were encountered: