Misleading setting name when restricting secrets to images

[picsel2]

Component

web-ui

Describe the bug

I wanted to use a secret within a step with commands. When setting the secret I thought that the image filter also applies to such steps. Now I found out the hard way, that it is apparently supposed only for plugins.

I had some trouble debugging that because the error message of the pipeline said

secret "registry_grabel_username" only allowed to be used by plugins by step "Package"

I suggest to use the expression "Plugin filter" instead of "Image filter" in the docs and UI.

Steps to reproduce

1. Set a secret with an image filter set.
2. Include a commands step with a matching image in the workflow.
3. Run the pipeline.
4. Notice the error message.

Expected behavior

Less confusing naming 😅

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"2.5.0"}

Additional context

No response

Validations

• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

[zc-devs]

Fixed by #4028