Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Secrets image filter docs #4028

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

zc-devs
Copy link
Contributor

@zc-devs zc-devs commented Aug 11, 2024

Renamed secrets image->plugins filter, improved description

@qwerty287
Copy link
Contributor

qwerty287 commented Aug 12, 2024

Does webkate import these changes too?

And can you make clear that a secret with plugin filter will not be available to regular steps? (Just generalize the commands part)

@zc-devs
Copy link
Contributor Author

zc-devs commented Aug 12, 2024

Does webkate import these changes too?

I know nothing about weblate.

And can you make clear that a secret with plugin filter will not be available to regular steps? (Just generalize the commands part)

Where, in docs or UI?
Docs mentions plugins. After that general steps.
UI contains only and also mentions general step in description.
Could you suggest changes?

@qwerty287
Copy link
Contributor

I know nothing about weblate.

Would be good to know. However, as you changed the source string, it will need a retranslation anyways, so I think you can also just revert the changes to the locales.

Could you suggest changes?

OK, it's fine for me.

@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Aug 13, 2024

Deployment of preview was torn down

@qwerty287 qwerty287 added the documentation docu & docs label Aug 14, 2024
@zc-devs zc-devs force-pushed the secrets-image-filter-docs branch from 4103859 to 81ee166 Compare August 15, 2024 17:11
@zc-devs
Copy link
Contributor Author

zc-devs commented Aug 15, 2024

@qwerty287

just revert the changes to the locales

Done.

@qwerty287 qwerty287 merged commit cf7a548 into woodpecker-ci:main Aug 15, 2024
7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Aug 15, 2024
1 task

To prevent abusing your secrets from malicious usage, you can limit a secret to a list of images. If enabled they are not available to any other plugin (steps without user-defined commands). If you or an attacker defines explicit commands, the secrets will not be available to the container to prevent leaking them.
To prevent abusing your secrets from malicious usage, you can limit a secret to a list of plugins. If enabled they are not available to any other plugin (steps without user-defined commands). If you or an attacker defines explicit commands, the secrets will not be available to the container to prevent leaking them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... it will if set disalow to be injected in any non plugin step where use can freely define commands ...

6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
1 task
@zc-devs zc-devs deleted the secrets-image-filter-docs branch November 11, 2024 08:48
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation docu & docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants