Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rolling semver tags, remove latest tag #4600

Merged
merged 7 commits into from
Dec 21, 2024
Merged

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Dec 21, 2024

fix #4597 fix #3131

  • Removing latest tag to avoid automatic major release upgrades
  • Add rolling tags for major and minor release versions (allows semi-automated upgrads and prevents from direct major upgrades)

@pat-s pat-s added feature add new functionality build CI pipeline related labels Dec 21, 2024
@qwerty287 qwerty287 added the breaking will break existing installations if no manual action happens label Dec 21, 2024
@qwerty287
Copy link
Contributor

What will happen if we publish a release like 2.10.0?

@pat-s
Copy link
Contributor Author

pat-s commented Dec 21, 2024

Oh dear, good point 🙈️

Changed it to the following

CI_COMMIT_TAG="v2.10.0"
short_tag=${CI_COMMIT_TAG%.*}
echo "$short_tag"
v2.10

@qwerty287
Copy link
Contributor

And what about 10.0.0? Same thing…

@qwerty287
Copy link
Contributor

And docs must get an update: https://woodpecker-ci.org/docs/administration/deployment-methods/docker-compose#docker-images

@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Dec 21, 2024

Deployment of preview was torn down

@pat-s pat-s merged commit e6aa0d8 into main Dec 21, 2024
7 checks passed
@pat-s pat-s deleted the feat/rolling-semver-tags branch December 21, 2024 10:52
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 21, 2024
1 task
@anbraten
Copy link
Member

3.0.0.rc.0 and other rc versions would still override major versions as explained in #4597.
Can't get why we need to drop latest. We could suggest people to use pinned version, if they want to use latest fine.

@pat-s
Copy link
Contributor Author

pat-s commented Dec 22, 2024

3.0.0.rc.0 and other rc versions would still override major versions as explained in #4597.

Sure but in this case users opted in to use this version on purpose and not by getting a background update due to a rolling tag.

Can't get why we need to drop latest. We could suggest people to use pinned version, if they want to use latest fine.

Even though some/most might do, the "a major upgrade happened and everything broke" issues will never stop this way, also because people often don't set a tag at all and hence will get latest implicitly.
By removing latest, you workaround this problem actively by forcing users to specify a tag they want.

If you think about it, why should there ever be a tag crossing major version automatically? This will always result in a functional disaster. Admins have to adjust the config anyhow for a major upgrade, so arguing with "it reduces admin work" doesn't work. But it pro-actively prevents issues for admins and issues posted to the project. Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking will break existing installations if no manual action happens build CI pipeline related feature add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected non-stable version for docker image woodpeckerci/woodpecker-server Docker Tag vX.X not working
4 participants