Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple when conditions #1087

Merged
merged 8 commits into from
Aug 14, 2022
Merged

Allow multiple when conditions #1087

merged 8 commits into from
Aug 14, 2022

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Aug 9, 2022 •
edited
Loading

closes #686

extracted from #770, originally created by @LamaAni

TODO

  • add tests
  • update yaml schema
  • update docs

Follow up

Use this feature for Woodpeckers own pipeline

@anbraten anbraten mentioned this pull request Aug 9, 2022
Merged
11 tasks
@anbraten anbraten added this to the 1.0.0 milestone Aug 10, 2022
@anbraten anbraten added feature add new functionality pipeline-config related to pipeline config files (.yaml) labels Aug 10, 2022
@anbraten anbraten marked this pull request as ready for review August 10, 2022 07:07
@anbraten anbraten requested a review from a team August 10, 2022 07:08
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Aug 10, 2022 •
edited
Loading

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1087.surge.sh

@anbraten anbraten changed the title Allow multi when conditions Allow multiple when conditions Aug 10, 2022
6543
6543 approved these changes Aug 14, 2022
View reviewed changes
Copy link
Member

@6543 6543 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good ... (and clean now)

can you add co-authored-by in the squash-commit?

@anbraten anbraten enabled auto-merge (squash) August 14, 2022 17:20
@anbraten anbraten merged commit e269890 into master Aug 14, 2022
@anbraten anbraten deleted the multi-when branch August 14, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
feature add new functionality pipeline-config related to pipeline config files (.yaml)
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Allow multiple when filters
3 participants
@anbraten @woodpecker-bot @6543