Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename forge-id to forge-remote-id #1418

Merged
merged 5 commits into from
Nov 15, 2022

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Nov 15, 2022

preparation for #1417

I want to use forge-id for the id of the correspondig forge of a repo. Therefore I would like to rename ForgeID to ForgeRemoteID. (Tell me if there is a better name for it).

@anbraten anbraten added this to the 1.0.0 milestone Nov 15, 2022
@anbraten anbraten added the refactor delete or replace old code label Nov 15, 2022
@anbraten anbraten requested a review from a team November 15, 2022 09:39
@anbraten anbraten mentioned this pull request Nov 15, 2022
7 tasks
@codecov-commenter
Copy link

Codecov Report

Base: 42.39% // Head: 42.38% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (ff0b3c1) compared to base (023d03d).
Patch coverage: 77.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1418      +/-   ##
==========================================
- Coverage   42.39%   42.38%   -0.01%     
==========================================
  Files         152      153       +1     
  Lines       10474    10479       +5     
==========================================
+ Hits         4440     4442       +2     
- Misses       5755     5757       +2     
- Partials      279      280       +1     
Impacted Files Coverage Δ
server/forge/bitbucketserver/bitbucketserver.go 0.00% <0.00%> (ø)
server/model/repo.go 0.00% <0.00%> (ø)
server/store/datastore/migration/migration.go 36.00% <ø> (ø)
server/forge/bitbucket/bitbucket.go 84.30% <33.33%> (ø)
server/forge/gitlab/gitlab.go 21.97% <37.93%> (ø)
...igration/013_rename_forge_id_to_forge_remote_id.go 40.00% <40.00%> (ø)
server/forge/github/github.go 15.89% <50.00%> (ø)
server/store/datastore/repo.go 53.33% <83.33%> (ø)
server/forge/bitbucket/convert.go 100.00% <100.00%> (ø)
server/forge/bitbucketserver/convert.go 85.52% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it.

@anbraten anbraten merged commit de8ea95 into woodpecker-ci:master Nov 15, 2022
@anbraten anbraten deleted the forge-remote-id branch November 15, 2022 14:01
simmstein pushed a commit to simmstein/woodpecker that referenced this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants