-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nomad Engine #1697
base: main
Are you sure you want to change the base?
Nomad Engine #1697
Conversation
Disable nomad's default retries Protect against some panics start of nomad backend more trying to get logs Logs work but other stuff is broken Working logs, pipelines work a lot small update, add todo
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1697.surge.sh |
@cullenmcdermott Are you still aiming to continue here? |
Hi! Yes I'd like to. I'll need to refresh myself on where I was with it. Are there any guidelines around what is needed for new engines like this or specific features I can/should defer? |
just match the interface and look at the "reference impl. (docker)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we continue I would like to wait for more requests by other users. Nomad seems TBH not to be the most used orchestrator and we should first of all make sure there is a real need for this before spending too much time implementing it.
Sounds good. I'll keep an eye on this and will be happy to continue working on it if there's more desire for this one. |
I am deploying a nomad cluster at the company I work for and this would be very nice for our ci/cd |
Since it seems there are a few people thinking this would be useful and we decided to include new backends if they are not too specific - which isn't the case here - I think it's fine to integrate this. |
Are you basing your decision on the 4 upvotes from the comment above? I'd be more hesitant here. Nomand is built on top of k8s and hence essentially a special k8s backend - in WP terms. It will always be very niche and the amount of work to maintain it must currently come from outside since I don't think any contributor/maintainer is actively using it. Which is why I am not sure if this should be included/supported officially. |
Yes, mainly.
I get your point here, but I there was a discussion about points like this some months ago, and the conclusion was: We allow it, but we don't maintain it and add an explicit warning to the docs that it's an experimental feature that must be supported by external devs. I think there a lot of features not used by maintainers, but still we include a lot of features. |
This is still pretty WIP but I figured I would go ahead and create a draft PR for this. Basic functionality seems to work, however the code needs cleaned up quite a bit still.
Closes #2158