Reverse proxy authentication to Woodpeck and Gitea #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mod adds option to authenticate user using HTTP header set by reverse proxy. It forwards specified HTTP header with authenticated username in requests to Gitea. Requirements: * Gitea must be configured for reverse proxy authentication and must accept HTTP header auth in API calls (Gitea fix IB#1107572). * Woodpecker must use its external host address in status URL-s sent to Gitea (Woodpecker fix IB#1107596). To enable set the following variables in woodpecker server environment (woodpecker running behind reverse proxy): * internal woodpecker server URL, i.e.: WOODPECKER_HOST_INTERNAL=http://192.168.1.100:8000 * enable reverse proxy auth in woodpecker and forwarding auth header to gitea: WOODPECKER_GITEA_REV_PROXY_AUTH=true * set name of header with authenticated username (set by reverse proxy), i.e.: WOODPECKER_GITEA_REV_PROXY_AUTH_HEADER=X-Forward-Username Author-Change-Id: IB#1107569
Missing information about file changes added. Fixes: 66d8ff7 Author-Change-Id: IB#1107569
Company name fixed. Fixes: 3888838 Author-Change-Id: IB#1107569
6543
reviewed
Jun 18, 2021
|
@pboguslawski can you rebase this pull ontop of master? |
Master merged in 94a4624. |
|
ok now all gitea pulls are now merged :) @pboguslawski the heavy woodpecker refactoring is now mostly done - wana rebase? |
|
As Woodpecker is now supporting Gitea login via OAuth which is quite convenient IMO, I would close this for now. Please feel free to reopen if you still want to get this in. |
|
OAuth should be optional not mandatory. Think of authenticating gitea and woodpecker user using reverse proxy and http header. This PR was replaced with #837 (adjusted to current master). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mod adds option to authenticate user using HTTP header set by
reverse proxy. It forwards specified HTTP header with authenticated
username in requests to Gitea.
Requirements:
Gitea must be configured for reverse proxy authentication and
must accept HTTP header auth in API calls (Allow Token API calls be authorized using the reverse-proxy header go-gitea/gitea#15119).
Woodpecker must use its external host address in status URL-s
sent to Gitea (Using configured server URL instead of obtained from request #175).
To enable set the following variables in woodpecker server
environment (woodpecker running behind reverse proxy):
internal woodpecker server URL, i.e.:
WOODPECKER_HOST_INTERNAL=http://192.168.1.100:8000enable reverse proxy auth in woodpecker and forwarding auth
header to gitea:
WOODPECKER_GITEA_REV_PROXY_AUTH=trueset name of header with authenticated username (set by
reverse proxy), i.e.:
WOODPECKER_GITEA_REV_PROXY_AUTH_HEADER=X-Forward-UsernameAuthor-Change-Id: IB#1107569