Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fallback check for old sqlite file location #2046

Merged
merged 3 commits into from
Jul 28, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 8 additions & 66 deletions cmd/server/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,8 @@ func setupStore(c *cli.Context) (store.Store, error) {
}

if driver == "sqlite3" {
if newDatasource, err := fallbackSqlite3File(datasource); err != nil {
log.Fatal().Err(err).Msg("fallback to old sqlite3 file failed")
} else {
datasource = newDatasource
if err := checkSqliteFileExist(datasource); err != nil {
log.Fatal().Err(err).Msg("check sqlite file")
}
}

Expand All @@ -97,69 +95,13 @@ func setupStore(c *cli.Context) (store.Store, error) {
return store, nil
}

// TODO: remove it in v1.1.0
// TODO: add it to the "how to migrate from drone docs"
func fallbackSqlite3File(path string) (string, error) {
const dockerDefaultPath = "/var/lib/woodpecker/woodpecker.sqlite"
const dockerDefaultDir = "/var/lib/woodpecker/drone.sqlite"
const dockerOldPath = "/var/lib/drone/drone.sqlite"
const standaloneDefault = "woodpecker.sqlite"
const standaloneOld = "drone.sqlite"

// custom location was set, use that one
if path != dockerDefaultPath && path != standaloneDefault {
return path, nil
}

// file is at new default("/var/lib/woodpecker/woodpecker.sqlite")
_, err := os.Stat(dockerDefaultPath)
if err != nil && !os.IsNotExist(err) {
return "", err
}
if err == nil {
return dockerDefaultPath, nil
func checkSqliteFileExist(path string) error {
_, err := os.Stat(path)
if err != nil && os.IsNotExist(err) {
log.Warn().Msgf("no sqlite3 file found, will create one at '%s'", path)
return nil
}

// file is at new default("woodpecker.sqlite")
_, err = os.Stat(standaloneDefault)
if err != nil && !os.IsNotExist(err) {
return "", err
}
if err == nil {
return standaloneDefault, nil
}

// woodpecker run in standalone mode, file is in same folder but not renamed
_, err = os.Stat(standaloneOld)
if err != nil && !os.IsNotExist(err) {
return "", err
}
if err == nil {
// rename in same folder should be fine as it should be same docker volume
log.Warn().Msgf("found sqlite3 file at '%s' and moved to '%s'", standaloneOld, standaloneDefault)
return standaloneDefault, os.Rename(standaloneOld, standaloneDefault)
}

// file is in new folder but not renamed
_, err = os.Stat(dockerDefaultDir)
if err != nil && !os.IsNotExist(err) {
return "", err
}
if err == nil {
// rename in same folder should be fine as it should be same docker volume
log.Warn().Msgf("found sqlite3 file at '%s' and moved to '%s'", dockerDefaultDir, dockerDefaultPath)
return dockerDefaultPath, os.Rename(dockerDefaultDir, dockerDefaultPath)
}

// file is still at old location
_, err = os.Stat(dockerOldPath)
if err == nil {
log.Fatal().Msgf("found sqlite3 file at old path '%s', please move it to '%s' and update your volume path if necessary", dockerOldPath, dockerDefaultPath)
}

// file does not exist at all
log.Warn().Msgf("no sqlite3 file found, will create one at '%s'", path)
return path, nil
return err
}

func setupQueue(c *cli.Context, s store.Store) queue.Queue {
Expand Down
14 changes: 14 additions & 0 deletions docs/docs/30-administration/20-migrate-from-drone.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Migrate from Drone to Woodpecker

## Migrate from Drone >= v1.0.0

We currently do not provide a way to do so.
If you are interested or have a custom script to do so, please get in contact with us.

## Migrate from Drone <= v0.8
6543 marked this conversation as resolved.
Show resolved Hide resolved

- Make sure you upgrade to Drone v0.8
- Upgrade to woodpecker v0.14.4, migration is run on startup
- If you use Sqlite3, rename `drone.sqlite` to `woodpecker.sqlite` and
Rename/Adjust volume-mount/folder from `/var/lib/drone/` to `/var/lib/woodpecker/`
- Upgrade to woodpecker v1.0.0, migration is run on startup
6543 marked this conversation as resolved.
Show resolved Hide resolved