-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running tests on arm64 runners #2605
Conversation
Nice ... i still want to wait until xgo has the patches merged :) |
Sure. Let's see how upstream goes. But a PoC was needed anyhow :) |
That issue looks unrelated AFAICS - it's not a compile issue but a missing file. The issue is I couldn't find a run where |
Given that the I've cleaned up the PR dummy changes to make it potentially mergable. |
Updated images to 1.22.1. Feedback would be great ;) |
it did run on x86 right now ... let me change the autoscaler to spawn arm ... not jet but soon ish |
what we could do is to explizite lable workflows to use x86 and then cange it to arm in here ... |
Certainly good for testing. But a bit of effort to do. Though I am meanwhile pretty sure the arm build fine. |
@6543 A bit hard to make some progress here. I am slowly loosing motivation a bit as I can't do anything on my side anymore besides asking/pinging for external action. both here and in If this is not important enough, we can also close it and just stay on |
the only thing blocking it is techknowlogick/xgo#224 so we can just make the autoscaler more inteligent and deploy arm and only if needed by workflow (label selector) use x64 |
is not blocking, there is a functional image built from this PR under my account |
well in this case we can just use that meanwhile ... just add a codecoment (todo: switch to main once X is merged...) |
This is what I am trying to express since the last five comments or so 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some IDEs can create a tasks tree from TODO:
commends.
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: 6543 <m.huber@kithara.com> Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
builds upon #2232
NB: the change
pats22/xgo:go-1.21.3
is only as long as techknowlogick/xgo#224 is not yet merged and an arm image is available upstream.