Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor docker backend and add more test coverage #2700

Merged
merged 16 commits into from
Jul 21, 2024
Merged

Refactor docker backend and add more test coverage #2700

merged 16 commits into from
Jul 21, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 2, 2023

some pipeline backend related refactors and tests

@6543 6543 added refactor delete or replace old code tests related to tests or other things CI check before merge skip-changelog labels Nov 2, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited
Loading

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (106508a) 34.87% compared to head (cba243d) 34.08%.
Report is 6 commits behind head on main.

❗ Current head cba243d differs from pull request most recent head fc0e33e. Consider uploading reports for the commit fc0e33e to get more accurate results

Files Patch % Lines
pipeline/backend/docker/docker.go 0.00% 18 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2700      +/-   ##
==========================================
- Coverage   34.87%   34.08%   -0.80%     
==========================================
  Files         228      212      -16     
  Lines       14772    13547    -1225     
==========================================
- Hits         5152     4617     -535     
+ Misses       9242     8575     -667     
+ Partials      378      355      -23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anbraten anbraten changed the title some refactors and more test coverage Some refactoring and more test coverage Nov 2, 2023
@6543 6543 requested a review from qwerty287 November 2, 2023 13:06
@6543 6543 enabled auto-merge (squash) November 2, 2023 13:40
@6543 6543 changed the title Some refactoring and more test coverage WIP: refactor pipeline backend and more test coverage Nov 2, 2023
@6543 6543 disabled auto-merge November 2, 2023 16:12
@6543 6543 added enhancement improve existing features wip and removed skip-changelog tests related to tests or other things CI check before merge labels Nov 2, 2023
@6543
Copy link
Member Author

6543 commented Nov 2, 2023

Well more ctx work need to be done ...

@anbraten anbraten marked this pull request as draft November 3, 2023 07:09
@anbraten anbraten changed the title WIP: refactor pipeline backend and more test coverage Refactor pipeline backend and add more test coverage Nov 3, 2023
@runephilosof-karnovgroup runephilosof-karnovgroup mentioned this pull request Dec 13, 2023
Closed
5 tasks
6543
6543 commented Jan 9, 2024
View reviewed changes
pipeline/pipeline.go Outdated Show resolved Hide resolved
@6543 6543 marked this pull request as ready for review July 21, 2024 19:11
@6543
Copy link
Member Author

6543 commented Jul 21, 2024

Well more ctx work need to be done ...

we did that now 🎉

@6543 6543 changed the title Refactor pipeline backend and add more test coverage Refactor docker backend and add more test coverage Jul 21, 2024
@6543 6543 enabled auto-merge (squash) July 21, 2024 19:18
@6543 6543 merged commit b2970db into woodpecker-ci:main Jul 21, 2024
7 checks passed
@6543 6543 deleted the nits branch July 21, 2024 19:49
@woodpecker-bot
Copy link
Collaborator

Tearing down https://woodpecker-ci-woodpecker-pr-2700.surge.sh

@woodpecker-bot woodpecker-bot mentioned this pull request Jul 21, 2024
Closed
1 task
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@6543
Refactor docker backend and add more test coverage (woodpecker-ci#2700)
b5175e4 
collection of some smal nit's and additions of tests
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
Merged
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
enhancement improve existing features refactor delete or replace old code wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@6543 @woodpecker-bot @qwerty287