-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert to previous red colors but do not use red color for text #2786
Revert to previous red colors but do not use red color for text #2786
Conversation
Thanks for looking into it again! I really like this approach. What do you think about creating a reusable |
I like the idea to re-use the look of the Vue notifications, and we can also adjust the |
…v2' into feat/dark_theme_red_color_usage_v2
@xoxys done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides that, looks good to me.
Revert red colors back introduced by #2778
But do not use red color for text on dark background anywhere
example: