Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove panic recovering #3162

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Remove panic recovering #3162

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40d5195
Remove panic recovering
qwerty287 Jan 10, 2024
736e196
Merge branch 'main' into log-rm-err
6543 Jan 10, 2024
a23d255
Merge branch 'main' into log-rm-err
qwerty287 Jan 11, 2024
7e9b479
Merge branch 'main' into log-rm-err
qwerty287 Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions server/queue/fifo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ package queue
import (
"container/list"
"context"
"runtime"
"sync"
"time"

Expand Down Expand Up @@ -241,17 +240,6 @@ func (q *fifo) process() {
return
}

defer func() {
// the risk of panic is low. This code can probably be removed
// once the code has been used in real world installs without issue.
if err := recover(); err != nil {
const size = 64 << 10
buf := make([]byte, size)
buf = buf[:runtime.Stack(buf, false)]
log.Error().Msgf("queue: unexpected panic: %v\n%s", err, buf)
}
}()

q.resubmitExpiredPipelines()
q.filterWaiting()
for pending, worker := q.assignToWorker(); pending != nil && worker != nil; pending, worker = q.assignToWorker() {
Expand Down