Allow separate gitea oauth URL

[qwerty287]

closes #3470

[woodpecker-bot]

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3513.surge.sh

[xoxys]

IMO, this should also be named _DEV_ to outline that this is not required in most production setup. I would also prefer OAuthURL over OAuth2URL but no strong feelings about this.

closes #3510 seems to be a drive-by fix that might better go in its own PR.

[qwerty287]

IMO, this should also be named _DEV_ to outline that this is not required in most production setup.

I don't think so as it's not a dev flag. Maybe we can add some note in docs that most won't need it?

I would also prefer OAuthURL over OAuth2URL but no strong feelings about this.

changed

[xoxys]

I don't think so as it's not a dev flag. Maybe we can add some note in docs that most won't need it?

But for what real world scenario this is required? It just applies to dev/test setups, otherwise you have an accessible external domain anyway, or am I wrong?

[qwerty287]

Hmm you're right, I just checked the issue again, will change it.

[anbraten]

If I didn't missed anything WOODPECKER_DEV_OAUTH_HOST is exactly doing the same already 🤔 . At least I am using it successfully locally with gitea during development.

[xoxys]

Yes me too, and I was wondering as well but had no time to check the details yet.

[qwerty287]

I don't think so as WOODPECKER_DEV_OAUTH_HOST is about the Woodpecker address/host used for redirection from forge, but the issue is about the Gitea address/host for redirection from WP to Gitea . I also suggested that first in the issue but it didn't solve the problem

[xoxys]

Yes, you are right, the WOODPECKER_GITEA_URL needs to be accessible from the container and from the browser. If you can't find a value that fits both environments, this new option is required. Makes sense to me.

[codecov]

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 36.02%. Comparing base (9c684b7) to head (19adc67).
Report is 1 commits behind head on main.

Files	Patch %	Lines
cmd/server/setup.go	0.00%	8 Missing ⚠️
server/forge/gitea/gitea.go	20.00%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3513      +/-   ##
==========================================
- Coverage   36.08%   36.02%   -0.06%     
==========================================
  Files         229      229              
  Lines       15489    15493       +4     
==========================================
- Hits         5589     5582       -7     
- Misses       9494     9504      +10     
- Partials      406      407       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.