Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp pin golangci version in makefile #3520

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Temp pin golangci version in makefile #3520

merged 2 commits into from
Mar 20, 2024

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Mar 20, 2024

Looks like something is broken in v1.57.x, and I don't think that's something that can be fixed on the end-user side:

https://ci.woodpecker-ci.org/repos/3780/pipeline/14131/33

WARN [runner] Can't process result by autogenerated_exclude processor: can't filter issue result.Issue{FromLinter:"contextcheck", Text:"Function `Start$1->runCron` should pass the context parameter", Severity:"", SourceLines:[]string(nil), Replacement:(*result.Replacement)(nil), Pkg:(*packages.Package)(0xc001871980), LineRange:(*result.Range)(nil), Pos:token.Position{Filename:"", Offset:0, Line:0, Column:0}, HunkPos:0, ExpectNoLint:false, ExpectedNoLintLinter:""}: no file path for issue 
WARN [runner] Can't process result by nolint processor: can't filter issue result.Issue{FromLinter:"contextcheck", Text:"Function `Start$1->runCron` should pass the context parameter", Severity:"", SourceLines:[]string(nil), Replacement:(*result.Replacement)(nil), Pkg:(*packages.Package)(0xc001871980), LineRange:(*result.Range)(nil), Pos:token.Position{Filename:"", Offset:0, Line:0, Column:0}, HunkPos:0, ExpectNoLint:false, ExpectedNoLintLinter:""}: no file path for issue 
WARN [runner/source_code] Failed to get line 0 for file : failed to get file  lines cache: can't get file  bytes from cache: can't read file : open : no such file or directory 

@xoxys xoxys requested a review from a team March 20, 2024 12:53
@xoxys xoxys merged commit 1a3eed2 into main Mar 20, 2024
7 checks passed
@xoxys xoxys deleted the pin-golangci branch March 20, 2024 13:02
@woodpecker-bot woodpecker-bot mentioned this pull request Mar 20, 2024
1 task
6543 added a commit that referenced this pull request Mar 20, 2024
This PR was opened by the
[ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go)
plugin. When you're ready to do a release, you can merge this
pull-request and a new release with version `2.4.1` will be created
automatically. If you're not ready to do a release yet, that's fine,
whenever you add more changes to `main` this pull-request will be
updated.

## Options

- [ ] Mark this version as a release candidate

##
[2.4.1](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.4.1)
- 2024-03-20

### 🔒 Security

- Only allow to deploy from push, tag and release
[[#3522](#3522)]

### 🐛 Bug Fixes

- Exclude setup from cli command exec.
[[#3523](#3523)]
- Fix uppercased env
[[#3516](#3516)]
- Fix env schema
[[#3514](#3514)]

### Misc

- Temp pin golangci version in makefile
[[#3520](#3520)]

---------

Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Co-authored-by: 6543 <m.huber@kithara.com>
lafriks pushed a commit that referenced this pull request Mar 21, 2024
Reverts: #3520

As we have enabled pre-commit updates in renovate now, I've increased
the `autoupdate_schedule` of pre-commit to the max value (there is no
way to disable it).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants