Add flag to only access public repositories on GitHub #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwerty287
added
forge/github
qwerty287
reviewed
Mar 29, 2024
|
By the way, does Woodpecker need only write access to webhooks? Or does it need to delete them, too? |
|
No, woodpecker deletes them when you disable a repo, so this scope is necessary. |
qwerty287
approved these changes
Mar 29, 2024
|
Branch is up-to-date (I think allowing changes just isn't a thing I can do because the fork is owned by an org) |
|
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3566.surge.sh |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
WOODPECKER_GITHUB_ONLY_PUBLICwhich instructs the GitHub client to only obtain clients which have permissions to operate on public repositories.We have tested these changes on our own instance and can report that at least the basic functionality works.
Someone please feel free to chime in if this breaks any other functionality of Woodpecker we weren't aware of.
Rationale: This follows the principle of least privilege. We run a public Woodpecker instance for an open-source project. We never intend to run it on anything but public repositories.
The standard permissions are rather scary though.
Read and write access to all public and private data including settings, deploy keys, code, collaboration invites, etc.
By restricting access to the following scopes:
admin:repo_hookrepo:statususer:emailread:orgwe can still have all the functionality Woodpecker needs (manage webhooks, update repository statuses, etc.) without the scary settings such as invites, writing to all aspects, etc.
New authorization dialog: