Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent-wide node selector #3608

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Agent-wide node selector #3608

merged 7 commits into from
Jun 3, 2024

Conversation

zc-devs
Copy link
Contributor

@zc-devs zc-devs commented Apr 12, 2024

Closes #3587

@qwerty287 qwerty287 added enhancement improve existing features backend/kubernetes labels Apr 14, 2024
@qwerty287 qwerty287 added this to the 2.6.0 milestone Jun 2, 2024
qwerty287
qwerty287 reviewed Jun 2, 2024
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved already, but missed the docs… Can you add docs for this env var?

pipeline/backend/kubernetes/flags.go Outdated Show resolved Hide resolved
zc-devs added 2 commits June 2, 2024 10:53
@zc-devs
Update flags.go
9a824d0 
align with annotations and labels
@zc-devs
docs
81d5ba2
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Jun 2, 2024 •
edited
Loading

Deployment of preview was torn down

@qwerty287
Copy link
Contributor

Can you run gofumpt? https://ci.woodpecker-ci.org/repos/3780/pipeline/16752/33

@codecov Codecov
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 25.88%. Comparing base (f47f482) to head (1d0843d).
Report is 9 commits behind head on main.

Files Patch % Lines
pipeline/backend/kubernetes/kubernetes.go 14.28% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3608      +/-   ##
==========================================
+ Coverage   24.99%   25.88%   +0.88%     
==========================================
  Files         357      361       +4     
  Lines       25767    26648     +881     
==========================================
+ Hits         6441     6898     +457     
- Misses      18833    19220     +387     
- Partials      493      530      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerty287 qwerty287 merged commit 065eebd into woodpecker-ci:main Jun 3, 2024
9 checks passed
@zc-devs zc-devs deleted the 3587-agent-wide-node-selector branch June 3, 2024 15:39
@woodpecker-bot woodpecker-bot mentioned this pull request Jun 3, 2024
Merged
1 task
@BrewTestBot BrewTestBot mentioned this pull request Jun 13, 2024
Merged
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@zc-devs @qwerty287 @6543
Agent-wide node selector (woodpecker-ci#3608)
961b16a 
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
backend/kubernetes enhancement improve existing features
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

Agent-wide node selector (K8s)
3 participants
@zc-devs @woodpecker-bot @qwerty287