Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize tag ref for gitea/forgejo #3664

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Sanitize tag ref for gitea/forgejo #3664

merged 1 commit into from
Apr 30, 2024

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Apr 30, 2024 •
edited
Loading

Fixes: #3665

We should still consider adding Forgejo as dedicated forge to woodpecker.

@xoxys
Copy link
Member Author

xoxys commented Apr 30, 2024

Tested on a local dev setup with forgejo v7:

image

Before:

CI_COMMIT_TAG=refs/tags/v1.1.0
CI_COMMIT_AUTHOR_EMAIL=woodpecker@noreply.10.168.64.121
CI_COMMIT_REF=refs/tags/refs/tags/v1.1.0

After:

CI_COMMIT_TAG=v1.2.0
CI_COMMIT_AUTHOR_EMAIL=woodpecker@noreply.10.168.64.121
CI_COMMIT_REF=refs/tags/v1.2.0

@xoxys xoxys added bug Something isn't working server forge/forgejo forgejo forge related labels Apr 30, 2024
@xoxys xoxys requested a review from a team April 30, 2024 07:14
pat-s
pat-s approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pat-s pat-s merged commit 7f776eb into main Apr 30, 2024
6 of 7 checks passed
@pat-s pat-s deleted the sanitize-ref branch April 30, 2024 07:59
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 30, 2024
Merged
1 task
@6543 6543 added this to the 2.5.0 milestone Apr 30, 2024
@qwerty287
Copy link
Contributor

We should still consider adding Forgejo as dedicated forge to woodpecker.

Now, yes, as it's a hard fork now. I disagreed on this when it was a soft fork.

Unfortunately, forgejo doesn't provide an SDK so we either have to use gitea's or write an own... (Of course we could ask them about forking the gitea one)

@BrewTestBot BrewTestBot mentioned this pull request Jun 1, 2024
Merged
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@xoxys @6543
Sanitize tag ref for gitea/forgejo (woodpecker-ci#3664)
98f84ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pat-s pat-s pat-s approved these changes

Assignees
No one assigned
Labels
bug Something isn't working forge/forgejo forgejo forge related server
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Tag ref contains prefix on forgejo v7
4 participants
@xoxys @qwerty287 @pat-s @6543