Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint go code with cspell #3706

Merged
merged 31 commits into from
May 24, 2024
Merged

Conversation

6543
Copy link
Member

@6543 6543 commented May 14, 2024

address #3705

@6543 6543 changed the title cspell lint cmd wip: cspell lint cmd May 14, 2024
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented May 14, 2024

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3706.surge.sh

@6543 6543 changed the title wip: cspell lint cmd cspell lint go code May 14, 2024
@6543 6543 marked this pull request as ready for review May 14, 2024 02:43
@6543 6543 added the refactor delete or replace old code label May 14, 2024
@xoxys
Copy link
Member

xoxys commented May 14, 2024

In general, I like that we add spellchecking to more areas. But is there no way to handle excludes in a central place? E.g. most imports could be excluded by a ignoreRegExpList setting?

@6543
Copy link
Member Author

6543 commented May 14, 2024

Well it is handled in one place at .cspell.json. 🤔

@xoxys
Copy link
Member

xoxys commented May 14, 2024

I'm talking about the // cspell: annotation behind a lot of import URLs.

@6543
Copy link
Member Author

6543 commented May 14, 2024

well yes because the usernames are mostly not in a dictionary and I don't want to add them to ours as we don't need them globaly

@xoxys
Copy link
Member

xoxys commented May 14, 2024

That's why I asked for a central ignoreRegExpList config and not dict entry. Basically something like:

"ignoreRegExpList": [
    ".*github.com/.*"
]

URLs should not be spellchecked at all.

@xoxys
Copy link
Member

xoxys commented May 14, 2024

@6543 6543 requested a review from xoxys May 23, 2024 13:08
.woodpecker/social.yaml Outdated Show resolved Hide resolved
.woodpecker/test.yaml Show resolved Hide resolved
agent/runner.go Outdated Show resolved Hide resolved
pipeline/backend/kubernetes/utils.go Show resolved Hide resolved
pipeline/backend/kubernetes/utils.go Outdated Show resolved Hide resolved
pipeline/backend/local/command.go Outdated Show resolved Hide resolved
@6543 6543 requested a review from xoxys May 24, 2024 16:34
@6543 6543 merged commit 42f2734 into woodpecker-ci:main May 24, 2024
6 of 7 checks passed
@6543 6543 deleted the cspell_more-dictionaries branch May 24, 2024 20:35
@anbraten anbraten changed the title cspell lint go code Lint go code with cspell May 24, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request May 27, 2024
1 task
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants