Migrate to maintained cron lib and remove seconds

[qwerty287]

Use https://github.com/gdgvda/cron and remove seconds from cron syntax to use standard cron.

[zc-devs]

If you build an image, I can test.

[qwerty287]

Started CI, wait a few minutes.

Note that I wrote a migration that will remove the seconds, but if you revert back you have to update all crons manually and add the seconds back

[woodpecker-bot]

Deployment of preview was torn down

[codecov]

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Project coverage is 26.89%. Comparing base (123c4ae) to head (dc125cf).
Report is 5 commits behind head on main.

Files	Patch %	Lines
.../store/datastore/migration/033_cron_without_sec.go	17.64%	11 Missing and 3 partials ⚠️
server/model/cron.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3785      +/-   ##
==========================================
- Coverage   26.89%   26.89%   -0.01%     
==========================================
  Files         394      395       +1     
  Lines       27467    27484      +17     
==========================================
+ Hits         7388     7391       +3     
- Misses      19380    19391      +11     
- Partials      699      702       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xoxys]

What about https://github.com/go-co-op/gocron? The one from gdgvda/crongdgvda/cron doesn't look that reliable as well.

[qwerty287]

What do you mean by "reliable"?

I also saw that but preferred the fork because it was much easier to migrate. But I can also use the gocron lib.

Besides that, the "reliability" is not that important actually. This is done internally - the libs are only used to determine the time of the next run.

[anbraten]

https://github.com/go-co-op/gocron is using https://github.com/robfig/cron internally

[xoxys]

What do you mean by "reliable"?

My main concern was the reputation of the owner/org. The repo has not many stars, the maintainer has nearly no activity on GitHub, same applies to the org.

If we just use the Parser, why not embed this part in the WP code directly? The parser code wasn't touched since 4 years, even in the new fork. However, I don't have a strong opinion on this and won't block you, I'm just a bit more careful about unpopular repos/authors.

[anbraten]

If we just use the Parser, why not embed this part in the WP code directly? The parser code wasn't touched since 4 years, even in the new fork. However, I don't have a strong opinion on this and won't block you, I'm just a bit more careful about unpopular repos/authors.

We could also just stick to the lib as it works AFAIK and just change the format to the one without seconds.

[pat-s]

If we would remove seconds, this would be a breaking change and should go into 3.0.

[pat-s]

Migrating to a maintained lib is certainly a good idea - in addition to removing seconds (which are of no practical use anyway).