Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancel states #3849

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Fix cancel states #3849

wants to merge 11 commits into from

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Jun 27, 2024

closes #2875
closes #833
closes #2062
closes #2911
closes #2197
closes #3848

Changes

  • use specific states for workflow and step updates
  • var renamings and comment improvements for improved readability
  • remove exit-code handling from workflow as workflow have no exit-code
  • wait for traces client.Update() which updates the step states before client.Done() is called so the workflows steps states are saved before we determine the workflows state from them

@anbraten anbraten added bug Something isn't working server agent refactor delete or replace old code build_pr_images If set, the CI will build images for this PR and push to Dockerhub labels Jun 27, 2024
@anbraten anbraten added this to the 2.7.0 milestone Jun 27, 2024
@anbraten anbraten mentioned this pull request Jun 28, 2024
3 tasks
@6543
Copy link
Member

6543 commented Jul 8, 2024

@anbraten beside the lint issue it looks ready

@anbraten
Copy link
Member Author

anbraten commented Jul 8, 2024

Yes, the general refactoring should be done. The runner_test could be enhanced. And it would be nice if someone reviewing would have a closer look on the switch of Exited to the Finished property, just to make sure I haven't missed anything.

@6543 6543 self-requested a review July 13, 2024 21:02
@6543 6543 modified the milestones: 2.7.0, 2.8.0 Jul 17, 2024
@qwerty287 qwerty287 added this to the 3.0.0 milestone Aug 11, 2024
@anbraten anbraten removed this from the 3.0.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent bug Something isn't working build_pr_images If set, the CI will build images for this PR and push to Dockerhub refactor delete or replace old code server
Projects
None yet
3 participants