Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JSON and SDK fields #3968

Merged
merged 9 commits into from
Aug 7, 2024
Merged

Refactor JSON and SDK fields #3968

merged 9 commits into from
Aug 7, 2024

Conversation

qwerty287
Copy link
Contributor

deprecations from #3806 and #3228

@qwerty287 qwerty287 added refactor delete or replace old code breaking will break existing installations if no manual action happens labels Jul 24, 2024
@qwerty287 qwerty287 added this to the 3.0.0 milestone Jul 24, 2024
@qwerty287 qwerty287 requested a review from a team July 24, 2024 15:30
@qwerty287 qwerty287 mentioned this pull request Jul 24, 2024
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Jul 24, 2024

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3968.surge.sh

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 26.87%. Comparing base (c864f24) to head (66446fb).
Report is 1 commits behind head on main.

Files Patch % Lines
...e/datastore/migration/034_rename_start_end_time.go 40.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3968      +/-   ##
==========================================
- Coverage   26.88%   26.87%   -0.01%     
==========================================
  Files         395      396       +1     
  Lines       27473    27489      +16     
==========================================
+ Hits         7387     7389       +2     
- Misses      19387    19397      +10     
- Partials      699      703       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

server/model/feed.go Outdated Show resolved Hide resolved
@6543 6543 merged commit 2081ca8 into woodpecker-ci:main Aug 7, 2024
9 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Aug 6, 2024
1 task
@qwerty287 qwerty287 deleted the json-sdk branch August 7, 2024 15:36
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
1 task
@anbraten anbraten mentioned this pull request Nov 22, 2024
4 tasks
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking will break existing installations if no manual action happens refactor delete or replace old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants