-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples of CI environment variable values #4009
Conversation
Deployment of preview was torn down |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea in general.
I don't think we should format all values as code, I'd prefer to have them as plain text instead.
I wouldn't say so... I prefer code |
Then let's hear more opinions - @woodpecker-ci/maintainers |
Here's how they get rendered (at least by GitHub): code, plain text, the middle ground (wrap list items and URLs that were not parsed correctly). |
I still prefer code (except lists, the separator shouldn't be part of the code) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I applied all three and reformatted the file with prettier. |
Not sure if you're interested in this; if not, I'll just keep it for my own reference.
I find it useful when writing build scripts because sometimes the exact way a value is formatted is not obvious, and you have to run a test job to find out.
Drone has something similar, but in a much less convenient form, spread over dozens of pages:
etc.