Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move event type descriptions from Terminology to Workflow Syntax #4062

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

not-my-profile
Copy link
Contributor

I expect a syntax reference to not just list the allowed values but to define them as well.

@qwerty287 qwerty287 added the documentation docu & docs label Aug 28, 2024
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems better for me as well. @woodpecker-ci/maintainers other opinios?

@anbraten anbraten changed the title docs: move event type descriptions from Terminology to Workflow Syntax Move event type descriptions from Terminology to Workflow Syntax Aug 29, 2024
@qwerty287
Copy link
Contributor

@not-my-profile please fix the broken anchor https://ci.woodpecker-ci.org/repos/3780/pipeline/19877/10#L104 and update the branch. If possible, granting update rights for maintainers is very helpful for us. Thanks!

@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Aug 30, 2024

Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the branch?

docs/docs/20-usage/15-terminology/index.md Show resolved Hide resolved
@qwerty287
Copy link
Contributor

Can you run prettier? https://ci.woodpecker-ci.org/repos/3780/pipeline/19903/19

@qwerty287
Copy link
Contributor

And the branch is outdated again...

@6543 6543 merged commit 99d169b into woodpecker-ci:main Aug 30, 2024
6 of 7 checks passed
@6543
Copy link
Member

6543 commented Aug 30, 2024

merged 🧙

@woodpecker-bot woodpecker-bot mentioned this pull request Aug 30, 2024
1 task
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation docu & docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants