Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run queue.process() in background #4115

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 16, 2024

Backported fix from #4114

before this it could happen that worklows that depend on other got stuck untill a new queue task was added

@6543 6543 added bug Something isn't working server labels Sep 16, 2024
@6543 6543 added enhancement improve existing features and removed bug Something isn't working labels Sep 16, 2024
@6543
Copy link
Member Author

6543 commented Sep 16, 2024

could not reproduce that strange bug where tasks depending on other tasks get stuck in the queu, so I can not check if this here do solve it ...

If you set the agent to only query one and then exec it afterwards you have a stuck task that a new agent can not query. (this pull fix that, so it's a bugfix)

@6543 6543 added bug Something isn't working and removed enhancement improve existing features labels Sep 16, 2024
@6543 6543 marked this pull request as ready for review September 16, 2024 10:02
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v2.7@6f5e069). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/queue/fifo.go 89.65% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/v2.7    #4115   +/-   ##
===============================================
  Coverage                ?   26.87%           
===============================================
  Files                   ?      394           
  Lines                   ?    27566           
  Branches                ?        0           
===============================================
  Hits                    ?     7407           
  Misses                  ?    19454           
  Partials                ?      705           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@6543 6543 requested a review from lafriks September 16, 2024 10:20
@anbraten anbraten changed the title Move queue.process() from event hook to background based Move queue.process() from event hook to background process Sep 16, 2024
@anbraten anbraten changed the title Move queue.process() from event hook to background process Run queue.process() in background Sep 16, 2024
@6543 6543 enabled auto-merge (squash) September 20, 2024 12:05
@6543 6543 merged commit 10d8a13 into woodpecker-ci:release/v2.7 Sep 20, 2024
6 of 7 checks passed
@6543 6543 deleted the move-queue-process-into-background-routine branch September 20, 2024 14:05
@woodpecker-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants