-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure cli exec has by default not the same prefix #4132
Ensure cli exec has by default not the same prefix #4132
Conversation
this prohibits colisions
Tearing down https://woodpecker-ci-woodpecker-pr-4132.surge.sh |
I would suggest to simply hard-code it in the cli to the same value we use in the agent. |
no hardcode will make colisins as we have right now ... but I could change the format to have a wp_ prefix. the problem is that we dont have a number that is even near the truth for each workflow |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4132 +/- ##
==========================================
- Coverage 26.20% 26.18% -0.02%
==========================================
Files 373 373
Lines 27034 27034
==========================================
- Hits 7084 7079 -5
- Misses 19294 19299 +5
Partials 656 656
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
well you normally dont need it but why remove it ... if we should not present this to the user we can just hide that flag |
*it's alrady hidden so why remove it etc ?!? |
Why do we need to support changing it? It's just extra code ... |
Well for those who wana change it at some point could also just compile the cli anyway ... |
@anbraten done |
this prohibits collisions
this make it similar to the server:
woodpecker/server/pipeline/stepbuilder/stepBuilder.go
Lines 289 to 295 in eebaa10