Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report custom labels set by agent admins back #4141

Merged
merged 15 commits into from
Oct 6, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 24, 2024

Let the server admin be able to see what custom labels an agent admin did set.

So he e.g. can debug why things are not picked up by some agent or when they pick up things they should not.

image


Sponsored by Kithara Software GmbH

@6543 6543 added server agent enhancement improve existing features labels Sep 24, 2024
pipeline/rpc/peer.go Outdated Show resolved Hide resolved
docs/docs/91-migrations.md Outdated Show resolved Hide resolved
@6543 6543 mentioned this pull request Oct 1, 2024
3 tasks
@6543 6543 enabled auto-merge (squash) October 6, 2024 14:53
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Oct 6, 2024

@6543 6543 merged commit f8cfda1 into woodpecker-ci:main Oct 6, 2024
7 checks passed
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 9.90099% with 91 lines in your changes missing coverage. Please review.

Project coverage is 26.46%. Comparing base (8b4d440) to head (4f43030).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
pipeline/rpc/proto/woodpecker.pb.go 0.00% 72 Missing ⚠️
agent/rpc/client_grpc.go 0.00% 8 Missing ⚠️
server/grpc/server.go 0.00% 8 Missing ⚠️
...astore/migration/016_add_custom_labels_to_agent.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4141      +/-   ##
==========================================
- Coverage   26.48%   26.46%   -0.03%     
==========================================
  Files         375      376       +1     
  Lines       27396    27455      +59     
==========================================
+ Hits         7255     7265      +10     
- Misses      19477    19525      +48     
- Partials      664      665       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woodpecker-bot woodpecker-bot mentioned this pull request Oct 6, 2024
1 task
@6543 6543 deleted the agent-report-al-labels-back branch October 6, 2024 15:17
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent enhancement improve existing features server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants