Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional error message on swagger v2 to v3 convert #4254

Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 26, 2024

just to have more debug infos

@6543 6543 added refactor delete or replace old code skip-changelog build CI pipeline related labels Oct 26, 2024
Copy link
Member

@anbraten anbraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is something in the process failing to wrap those errors?

cmd/server/woodpecker_docs_gen.go Outdated Show resolved Hide resolved
cmd/server/woodpecker_docs_gen.go Outdated Show resolved Hide resolved
cmd/server/woodpecker_docs_gen.go Outdated Show resolved Hide resolved
cmd/server/woodpecker_docs_gen.go Outdated Show resolved Hide resolved
6543 and others added 3 commits October 27, 2024 09:56
Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>
Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.52%. Comparing base (ddd55ee) to head (b570a29).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4254      +/-   ##
==========================================
+ Coverage   26.47%   26.52%   +0.05%     
==========================================
  Files         376      377       +1     
  Lines       27465    27450      -15     
==========================================
+ Hits         7270     7281      +11     
+ Misses      19530    19504      -26     
  Partials      665      665              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@6543
Copy link
Member Author

6543 commented Oct 27, 2024

Is something in the process failing to wrap those errors?

well yes if it panics and the e.g. io operation failed ... you jsut get an generic error but no idea what it tryed to do ... this helped me debug it ...

@6543 6543 requested a review from anbraten October 27, 2024 10:19
@qwerty287 qwerty287 merged commit 0b46545 into woodpecker-ci:main Nov 2, 2024
6 of 7 checks passed
@qwerty287 qwerty287 deleted the error-handling-swagger-convert branch November 2, 2024 08:32
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 2, 2024
1 task
@qwerty287 qwerty287 changed the title Add additionall error message on swagger v2 to v3 convert Add additional error message on swagger v2 to v3 convert Nov 8, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI pipeline related refactor delete or replace old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants