Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate routes instead of anchors #4285

Merged
merged 18 commits into from
Nov 19, 2024
Merged

Use separate routes instead of anchors #4285

merged 18 commits into from
Nov 19, 2024

Conversation

qwerty287
Copy link
Contributor

first part of #3827

@qwerty287 qwerty287 added ui frontend related refactor delete or replace old code labels Nov 2, 2024
@qwerty287 qwerty287 added this to the 3.0.0 milestone Nov 2, 2024
@qwerty287 qwerty287 requested a review from a team November 2, 2024 14:18
anbraten
anbraten reviewed Nov 4, 2024
View reviewed changes
web/src/router.ts Show resolved Hide resolved
web/src/views/admin/AdminSettingsWrapper.vue Outdated Show resolved Hide resolved
anbraten
anbraten reviewed Nov 8, 2024
View reviewed changes
web/src/views/admin/AdminSettingsWrapper.vue Outdated Show resolved Hide resolved
web/src/views/org/settings/OrgSettingsWrapper.vue Outdated Show resolved Hide resolved
web/src/components/layout/scaffold/Tab.vue Outdated Show resolved Hide resolved
web/src/router.ts Show resolved Hide resolved
@qwerty287
Copy link
Contributor Author

@anbraten I just changed it now to use router-link instead of button to solve all the issues you had

@anbraten
Copy link
Member

I just changed it now to use router-link instead of button to solve all the issues you had

That's smart as we don't have to extract the route matching logic and in addition get open to new tab with proper links

anbraten
anbraten previously approved these changes Nov 19, 2024
View reviewed changes
@anbraten anbraten self-requested a review November 19, 2024 10:33
@anbraten anbraten dismissed their stale review November 19, 2024 10:33

tabs are currently duplicated

anbraten
anbraten approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@anbraten anbraten left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything seems to work now
@qwerty287 Thanks for the nice work. Feel free to merge or adjust

@6543 6543 merged commit 95e464b into woodpecker-ci:main Nov 19, 2024
6 of 7 checks passed
@woodpecker-bot
Copy link
Collaborator

Tearing down https://woodpecker-ci-woodpecker-pr-4285.surge.sh

@woodpecker-bot woodpecker-bot mentioned this pull request Nov 19, 2024
Merged
1 task
pat-s pushed a commit that referenced this pull request Nov 19, 2024
@qwerty287 @anbraten @pat-s
Use separate routes instead of anchors (#4285)
879c1e2 
Co-authored-by: Anbraten <anton@ju60.de>
@qwerty287 qwerty287 deleted the sep-routes branch November 19, 2024 14:42
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6543 6543 6543 approved these changes

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
refactor delete or replace old code ui frontend related
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@qwerty287 @anbraten @woodpecker-bot @6543