address review lint issues

[6543]

address lint errors ( https://ci.woodpecker-ci.org/repos/3780/pipeline/22530/31 )

[codecov]

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 27.04%. Comparing base (e13085b) to head (6a37f67).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
pipeline/backend/kubernetes/kubernetes.go	0.00%	6 Missing ⚠️
server/store/datastore/migration/common.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4354      +/-   ##
==========================================
- Coverage   27.06%   27.04%   -0.02%     
==========================================
  Files         379      379              
  Lines       27752    27752              
==========================================
- Hits         7511     7506       -5     
- Misses      19572    19577       +5     
  Partials      669      669              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[woodpecker-bot]

Tearing down https://woodpecker-ci-woodpecker-pr-4354.surge.sh

[xoxys]

While its nice that we skip some steps/workflows depending on the changed files, we somehow miss some breaking changes that should have been covered by the introduced PR CI run already. There was another one today #4353

[qwerty287]

Yes, but the reason for this is that there was a golangci-lint update and we always use the latest version.

[xoxys]

Ah didnt know, thanks. Is there a reason to use latest instead of pinning + automerge?

[qwerty287]

Not that I know...