Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and warn of list syntax of environment #4358

Merged
merged 7 commits into from
Nov 17, 2024
Merged

Deprecate and warn of list syntax of environment #4358

merged 7 commits into from
Nov 17, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 11, 2024 •
edited
Loading

Close #4306

also better detection of secrets legacy syntax

@6543 6543 added the enhancement improve existing features label Nov 11, 2024
@6543 6543 requested a review from qwerty287 November 11, 2024 19:42
@6543 6543 added the engine change how the pipeline engine works label Nov 11, 2024
@6543 6543 mentioned this pull request Nov 11, 2024
Merged
@6543 6543 requested a review from xoxys November 13, 2024 13:08
xoxys
xoxys reviewed Nov 13, 2024
View reviewed changes
pipeline/frontend/yaml/linter/linter.go Outdated Show resolved Hide resolved
pipeline/frontend/yaml/linter/linter.go Outdated Show resolved Hide resolved
pipeline/frontend/yaml/linter/linter_test.go Outdated Show resolved Hide resolved
pipeline/frontend/yaml/linter/linter_test.go Outdated Show resolved Hide resolved
@6543 @xoxys
Apply suggestions from code review
7e854aa 
Co-authored-by: Robert Kaussow <xoxys@rknet.org>
@6543 6543 requested a review from xoxys November 13, 2024 14:35
@xoxys
Copy link
Member

xoxys commented Nov 14, 2024

Shouldn't this PR go to main first and the backported to release/v2.8?

@6543
Copy link
Member Author

6543 commented Nov 14, 2024 •
edited
Loading

@xoxys well that's exactly what this pull try to solve. in main, the environment syntax already got removed completely! but it was never deprecated before - so this pull does so for the next release those targeting the release branch

@xoxys
Copy link
Member

xoxys commented Nov 14, 2024 •
edited
Loading

Ah ok sorry, got it 👍 I think thats because the plan was to release 3.0 next.

@6543
Copy link
Member Author

6543 commented Nov 14, 2024

No the plan was to release v2.8.0 as the legacy environment syntax is currently completly valid in the latest release.

And pipeline congig changes must be depricated before a next release is allowed to let it error out.

Those this pull is needed and ned to be released before next release made from main e.g. 3.0.0

Those a 2.8.0 must be released containing a deprication

This pull does tje deprication

@6543 6543 changed the title Deprecate and detect list syntax of environment Deprecate and warn of list syntax of environment Nov 14, 2024
@6543 6543 added this to the 2.8.0 milestone Nov 17, 2024
@qwerty287 qwerty287 merged commit 092ea7b into woodpecker-ci:release/v2.8 Nov 17, 2024
5 of 7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 13, 2024
Merged
1 task
@6543 6543 deleted the linter_depricate-list-envs branch November 19, 2024 14:17
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

@xoxys xoxys Awaiting requested review from xoxys

Assignees
No one assigned
Labels
engine change how the pipeline engine works enhancement improve existing features
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@6543 @xoxys @qwerty287