Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend approval options (#3348) #4429

Merged
merged 19 commits into from
Nov 25, 2024
Merged

Extend approval options (#3348) #4429

merged 19 commits into from
Nov 25, 2024

Conversation

anbraten
Copy link
Member

Backport of #3348

@anbraten anbraten added enhancement improve existing features security labels Nov 21, 2024
@anbraten anbraten added this to the 2.8.0 milestone Nov 21, 2024
anbraten
anbraten commented Nov 21, 2024
View reviewed changes
server/store/datastore/migration/017_gated_to_require_approval.go Outdated Show resolved Hide resolved
docs/docs/20-usage/75-project-settings.md Show resolved Hide resolved
server/api/repo.go Outdated Show resolved Hide resolved
@6543
Copy link
Member

6543 commented Nov 23, 2024

Time to address things?

@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Nov 23, 2024 •
edited
Loading

Deployment of preview was torn down

@6543 6543 mentioned this pull request Nov 25, 2024
Merged
@6543
Copy link
Member

6543 commented Nov 25, 2024

with my last commit and #4456 this is non breaking anymore :)

6543
6543 reviewed Nov 25, 2024
View reviewed changes
server/pipeline/gated.go Outdated Show resolved Hide resolved
6543
6543 reviewed Nov 25, 2024
View reviewed changes
server/api/repo.go Outdated Show resolved Hide resolved
6543
6543 reviewed Nov 25, 2024
View reviewed changes
cli/repo/repo_update.go Outdated Show resolved Hide resolved
@6543 6543 requested a review from pat-s November 25, 2024 18:16
anbraten
anbraten commented Nov 25, 2024
View reviewed changes
cli/repo/repo_update.go Outdated Show resolved Hide resolved
server/api/repo.go Outdated Show resolved Hide resolved
docs/docs/20-usage/75-project-settings.md Outdated Show resolved Hide resolved
server/pipeline/gated.go Outdated Show resolved Hide resolved
@6543 6543 added the highlight label Nov 25, 2024
6543
6543 reviewed Nov 25, 2024
View reviewed changes
server/api/repo.go Outdated Show resolved Hide resolved
@6543
Copy link
Member

6543 commented Nov 25, 2024

#4429 (comment)

For new repos this is actually not required and could stay as is.

Well I still would say this is a soft breaking change if we add it back ... and the new migration at #4456 do take it into account already

@6543
Copy link
Member

6543 commented Nov 25, 2024

PS: feel free to update #4456 after you are done here as you see fit :)

@anbraten anbraten requested a review from 6543 November 25, 2024 19:23
@anbraten anbraten enabled auto-merge (squash) November 25, 2024 19:53
@anbraten anbraten merged commit cc3f041 into woodpecker-ci:release/v2.8 Nov 25, 2024
5 of 7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 25, 2024
Merged
1 task
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoxys xoxys xoxys left review comments

@6543 6543 6543 approved these changes

@pat-s pat-s Awaiting requested review from pat-s

Assignees
No one assigned
Labels
enhancement improve existing features highlight security
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anbraten @6543 @woodpecker-bot @xoxys @pat-s