-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't log DB passwords #4583
Don't log DB passwords #4583
Conversation
We don't even parse the data source later on... So yeah, you are right, no easy way to get just particular information. |
Tearing down https://woodpecker-ci-woodpecker-pr-4583.surge.sh |
URL could be split into 5 parts (separate env vars): host, port, database name, user, password. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4583 +/- ##
==========================================
+ Coverage 28.23% 28.25% +0.01%
==========================================
Files 399 399
Lines 28239 28239
==========================================
+ Hits 7973 7978 +5
+ Misses 19561 19556 -5
Partials 705 705 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
as of #4551 (comment)