Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log DB passwords #4583

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Don't log DB passwords #4583

merged 3 commits into from
Dec 18, 2024

Conversation

qwerty287
Copy link
Contributor

@qwerty287 qwerty287 added this to the 3.0.0 milestone Dec 18, 2024
@qwerty287 qwerty287 requested a review from a team December 18, 2024 14:01
@xoxys
Copy link
Member

xoxys commented Dec 18, 2024

We don't even parse the data source later on... So yeah, you are right, no easy way to get just particular information.

@qwerty287 qwerty287 enabled auto-merge (squash) December 18, 2024 14:14
@qwerty287 qwerty287 merged commit b4f5d62 into woodpecker-ci:main Dec 18, 2024
7 checks passed
@qwerty287 qwerty287 deleted the omit-source branch December 18, 2024 14:46
@woodpecker-bot
Copy link
Collaborator

@woodpecker-bot woodpecker-bot mentioned this pull request Dec 18, 2024
1 task
@zc-devs
Copy link
Contributor

zc-devs commented Dec 18, 2024

URL could be split into 5 parts (separate env vars): host, port, database name, user, password.
This way we can not only log parameters and do not log password, but also store host, port, database name in Kubernetes ConfigMap and user, password in Secret.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.25%. Comparing base (8788794) to head (9da9229).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/server/setup.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4583      +/-   ##
==========================================
+ Coverage   28.23%   28.25%   +0.01%     
==========================================
  Files         399      399              
  Lines       28239    28239              
==========================================
+ Hits         7973     7978       +5     
+ Misses      19561    19556       -5     
  Partials      705      705              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xoxys added a commit that referenced this pull request Dec 19, 2024
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
pat-s pushed a commit that referenced this pull request Dec 19, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants