Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plain output: render confidence #19

Closed
woodruffw opened this issue Sep 21, 2024 · 3 comments
Closed

Plain output: render confidence #19

woodruffw opened this issue Sep 21, 2024 · 3 comments
Assignees
Labels
cli enhancement New feature or request

Comments

@woodruffw
Copy link
Owner

Follow-on to #18: we render the severity, but not the confidence currently. Need to figure out a way to shoehorn the latter into annotate_snippets's data model.

@woodruffw woodruffw self-assigned this Sep 21, 2024
@ubiratansoares
Copy link
Contributor

Hey @woodruffw ! I was exploring how we could achieve something around this, how about using Message::footer?

I gave a small try on it, and I've managed to get something like


$> cargo run -- tests/test-data/artipacked.yml

🌈 completed artipacked.yml
warning[artipacked]: credential persistence through GitHub Actions artifacts
  --> tests/test-data/artipacked.yml:13:9
   |
13 |       - uses: actions/checkout@v4
   |         ------------------------- does not set persist-credentials: false
   |
   = note: audit confidence → Low

We can customize what we have in the footer message, including colors and etc (no strong opinion here).

@woodruffw
Copy link
Owner Author

We can customize what we have in the footer message, including colors and etc (no strong opinion here).

Nice, that looks great! Thanks for looking into it; send a PR and I'll do a full review 🙂

@woodruffw
Copy link
Owner Author

Closing for now; we can iterate on the display in a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants