Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improves plain output with audit confidence #119

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

ubiratansoares
Copy link
Contributor

@ubiratansoares ubiratansoares commented Nov 4, 2024

Related to #19

Self-explained. This is a super simple proposal, eventually we can improve by implementing Display for Confidence, adding colors, etc.

Testing this PR :

  • Pull this branch
  • Run against some Workflow with existing audits
cargo run -- tests/test-data/hardcoded-credentials.yml

🌈 completed hardcoded-credentials.yml
error[hardcoded-container-credentials]: hardcoded credential in GitHub Actions container configurations
  --> tests/test-data/hardcoded-credentials.yml:15:7
   |
15 |         credentials:
   |  _______^
16 | |         username: user
17 | |         password: hackme
   | |________________________^ container registry password is hard-coded
   |
   = note: audit confidence → High

@ubiratansoares ubiratansoares changed the title Improves plain output with audit confidence feat: improves plain output with audit confidence Nov 4, 2024
Copy link
Owner

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @ubiratansoares!

@woodruffw woodruffw added enhancement New feature or request cli labels Nov 4, 2024
@woodruffw woodruffw merged commit c4b20de into woodruffw:main Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants