Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: template-injection: more safe contexts #309

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

woodruffw
Copy link
Owner

github.event.before and github.event.after are always SHA references, when present.

github.event.before is documented but github.event.after is seemingly not -- I found independent corroboration here: https://www.kenmuse.com/blog/the-many-shas-of-a-github-pull-request/

See curl/curl#15746.

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw added the bugfix Fixes a known bug label Dec 16, 2024
@woodruffw woodruffw self-assigned this Dec 16, 2024
@woodruffw woodruffw merged commit c057958 into main Dec 16, 2024
19 checks passed
@woodruffw woodruffw deleted the ww/fp-contexts branch December 16, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant