New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle context accesses following calls #340

Draft

woodruffw wants to merge 1 commit into main from ww/bug-339

+27 −13

Owner

woodruffw commented Dec 20, 2024

WIP; these grammar changes mean the syntax tree itself is different, so I need to update the walk as well.

Fixes #339.


          fix: handle context accesses following calls

4b8fc3f

Signed-off-by: William Woodruff <william@yossarian.net>

woodruffw added the bugfix label

woodruffw self-assigned this

Owner Author

woodruffw commented Dec 20, 2024

Some notes for myself:

The Context node is now insufficiently expressive: an expression like fromJson(steps.runs.outputs.data).workflow_runs[0].id should be:

Context
  Call { fromJson args: Context { lit:steps, lit:runs, lit:outputs, lit:data } }
  lit:workflow_runs
  Index { 0 }
  lit:id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix