Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cache control types #347

Merged
merged 5 commits into from
Dec 23, 2024
Merged

refactor: cache control types #347

merged 5 commits into from
Dec 23, 2024

Conversation

woodruffw
Copy link
Owner

@woodruffw woodruffw commented Dec 23, 2024

WIP. Trying to flatten the states here a bit.

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw added the refactor Refactoring tasks label Dec 23, 2024
@woodruffw woodruffw self-assigned this Dec 23, 2024
Signed-off-by: William Woodruff <william@yossarian.net>
Comment on lines 29 to 37
/// The input that controls the behavior of a configurable caching action.
struct CacheControlInput {
/// What kind of toggle the input is.
toggle: CacheToggle,
/// The field that controls the caching action's behavior.
field_name: &'static str,
/// The type of the field that controls the caching action's behavior.
field_type: CacheControlFieldType,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loved this ❤️

Signed-off-by: William Woodruff <william@yossarian.net>
Make it an enum struct variant.

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw marked this pull request as ready for review December 23, 2024 18:50
@woodruffw woodruffw merged commit be7c7f2 into main Dec 23, 2024
5 checks passed
@woodruffw woodruffw deleted the ww/cache-control-refactor branch December 23, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants