test: adds acceptance tests on top of json-formatted output #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubiratansoares
commented
Nov 1, 2024
| let auditable = workflow_under_test("artipacked.yml"); | ||
| let cli_args = ["--format", "json", &auditable]; | ||
|
|
||
| let execution = zizmor().args(cli_args).unwrap(); |
There was a problem hiding this comment.
Quick note : this unwrap() is not the same one from Result or Option.
args() returns a Command type, hence there is no way to propagate an error here
There was a problem hiding this comment.
Makes sense, thanks for explaining. Also TIL that #[test] functions can return result types!
Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
I tried to cover all scenarios* that don't depend on the Github API token for now, but if you want I can add then by tweaking a bit the CI pipeline and using the
GITHUB_TOKENissued by GHA on these tests.In addition, I did my best to make the tests read as simple as possible, moving some boilterplate into helper functions.
Let me know your thoughs!