Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed invalid sort value type error #69

Merged

Conversation

piotrbelina
Copy link
Contributor

@piotrbelina piotrbelina commented Feb 5, 2018

Hello Máté,

I'm sending a fix for invalid sort attribute value.

For example

GET /api/v1/foo?sort[company_id]=asc

Actual error:

Type error: explode() expects parameter 2 to be string, array given on /vendor/woohoolabs/yin/src/JsonApi/Request/Request.php line 286

Expected some 400 exception

Cheers,
Piotr

@kocsismate
Copy link
Member

Hi Piotr,

That's awesome :) I'll add the same check for the include query param, and then I'll release Yin 2.0.6!

@kocsismate kocsismate merged commit ec09233 into woohoolabs:2.0 Feb 6, 2018
@kocsismate
Copy link
Member

kocsismate commented Feb 6, 2018

@piotrbelina I've done what I wanted (I even added a fix from 3.0). Please have a look at this: 4ffaccd If everything seems to be ok, I'll ship the release.

@piotrbelina
Copy link
Contributor Author

@kocsismate looks great :)

@piotrbelina piotrbelina deleted the feature/fix-invalid-sort-value branch February 6, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants