feat: add aave strategy #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb-alexcq
reviewed
Apr 16, 2024
Comment on lines
48
to
58
| uint256 beforeBal = balanceOfWant(); | ||
|
|
||
| // claim all rewards to the vault | ||
| IAaveV3Incentives(incentivesController).claimAllRewards(rewardAssets, address(vault)); | ||
|
|
||
| uint256 wantHarvested = balanceOfWant() - beforeBal; | ||
| uint256 fee = chargePerformanceFee(wantHarvested); | ||
| deposit(); | ||
|
|
||
| lastHarvest = block.timestamp; | ||
| emit StratHarvest(msg.sender, wantHarvested - fee, balanceOf()); |
There was a problem hiding this comment.
No need to calculate the balance, charge perf fee and deposit.
fb-alexcq
reviewed
Apr 16, 2024
| uint256 beforeBal = balanceOfWant(); | ||
|
|
||
| // claim all rewards to the vault | ||
| IAaveV3Incentives(incentivesController).claimAllRewards(rewardAssets, address(vault)); |
There was a problem hiding this comment.
This API supports directly claiming into the specified address
|
fb-alexcq
reviewed
Apr 16, 2024
Comment on lines
+25
to
+27
| address public constant aavePool = address(0x794a61358D6845594F94dc1DB02A252b5b4814aD); // Aave: Pool V3 | ||
| address public constant incentivesController = address(0x929EC64c34a17401F460460D4B9390518E5B473e); // Aave: Incentives V3 | ||
| address public constant dataProvider = address(0x69FA688f1Dc47d4B5d8029D5a35FB7a548310654); // Aave: Pool Data Provider V3 |
There was a problem hiding this comment.
@0xmer1in could you please help double check these addresses in deployment?
1. No need to calculate the balance, charge perf fee and deposit. 2. add reward treasury address, directly claiming into this address
chore: upgrade
0xmer1in
force-pushed
the
Aave-Strategy
branch
3 times, most recently
from
295447d to
81535ec
Compare
chore: upgrade fix: compile && format chore: update emergencyExit permission chore: rename back to the origin
0xmer1in
approved these changes
Apr 16, 2024
fb-alexcq
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.