This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Issue
Button
컴포넌트 focus 스타일 제거 #500✅ Tasks
⏰ Time Difference
📝 Note
focus 시 테두리 스타일은 box-shadow 속성을 통해 만들고 있는데, 배경색이 달라지면 그에 맞춰 구현하기가 좀 까다로워 집니다.
따라서 현재 variant에 따라 다른 동작을 보입니다.
2023-10-01.9.56.37.mov
또한 현재 버튼의 테두리를 인지 할 새 없이 바로 페이지가 이동하는 경우가 대부분이기 때문에, 삭제해도 UX는 크게 변경점이 없다고 생각했습니다.
추가적으로
Button
컴포넌트 자체에Ripple
컴포넌트를 적용해도 괜찮을 것 같지만, 마찬가지로의 이유때문에 도입은 고려해야할 것 같습니다.