Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] MemberActivity 리팩터링 #811

Closed
hong-sile opened this issue Oct 31, 2023 · 0 comments · Fixed by #827
Closed

[REFACTOR] MemberActivity 리팩터링 #811

hong-sile opened this issue Oct 31, 2023 · 0 comments · Fixed by #827
Assignees
@hong-sile
Labels
Backend 백엔드 관련 이슈 High Priority 리뷰 우선순위가 높은 PR 리팩터링 테스트 코드의 검증 값이 변환하지 않고 코드 변경

Comments

@hong-sile
Copy link
Collaborator

📌 어떤 기능을 리팩터링 하나요?

  • MemberActivity 반환값을 논의한 형태로 리팩터링

예상 소요 시간

  • 2시간
@hong-sile hong-sile added Backend 백엔드 관련 이슈 리팩터링 테스트 코드의 검증 값이 변환하지 않고 코드 변경 High Priority 리뷰 우선순위가 높은 PR labels Oct 31, 2023
@hong-sile hong-sile self-assigned this Oct 31, 2023
hong-sile added a commit that referenced this issue Nov 2, 2023
@hong-sile
feat: MemberRepository에 Exception을 반환하는 기능을 안으로 추가
819ed48 
#811
hong-sile added a commit that referenced this issue Nov 2, 2023
@hong-sile
refactor: 불필요한 Member updateProfileUrl 삭제
2b50448 
#811
hong-sile added a commit that referenced this issue Nov 2, 2023
@hong-sile
refactor: MemberActivityService Query와 Command 로 분리
734844c 
#811
hong-sile added a commit that referenced this issue Nov 2, 2023
@hong-sile
style: 코드 정렬
0b054ae 
#811
hong-sile added a commit that referenced this issue Nov 2, 2023
@hong-sile
refactor: MemberActivity 반환값 변경
bc0015f 
#811
hong-sile added a commit that referenced this issue Nov 2, 2023
@hong-sile
feat: Member에서 openProfileUrl 삭제
d1bd971 
#811
hong-sile added a commit that referenced this issue Nov 2, 2023
@hong-sile
test: 문서화 테스트에서 responsefileds 정의
16508ef 
#811
@hong-sile hong-sile mentioned this issue Nov 2, 2023
Merged
hong-sile added a commit that referenced this issue Nov 2, 2023
@hong-sile
test: 테스트 오류 수정
e1e24e2 
#811
hong-sile added a commit that referenced this issue Nov 2, 2023
@hong-sile
merge: memberActivity 리팩터링
854f95e 
Refactor/#811 member activity 리팩터링
@hong-sile hong-sile mentioned this issue Nov 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hong-sile hong-sile

Labels
Backend 백엔드 관련 이슈 High Priority 리뷰 우선순위가 높은 PR 리팩터링 테스트 코드의 검증 값이 변환하지 않고 코드 변경
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/#819 member 반환값 변경 woowacourse-teams/2023-emmsale
1 participant
@hong-sile