Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#104 로그인 http 메서드 수정 및 authorization extractor 예외 추가 #106

Conversation

hyeonjerry
Copy link
Collaborator

#️⃣연관된 이슈

📝작업 내용

  • 로그인 api http 메서드 수정
  • Authorization 헤더가 null일 경우 예외 처리 추가

@hyeonjerry hyeonjerry added Backend 백엔드 관련 이슈 리팩터링 테스트 코드의 검증 값이 변환하지 않고 코드 변경 labels Jul 26, 2023
@hyeonjerry hyeonjerry self-assigned this Jul 26, 2023
Copy link
Collaborator

@hong-sile hong-sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한 부분만 조금 걸리네요 이 부분만 확인해주시면, 될 것 같습니다.

}
validateAuthorizationHeader(authorizationHeader);

String authHeaderValue = authorizationHeader.substring(BEARER_TYPE.length()).trim();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authorization 타입이 Bearer가 아닌 다른 타입이 들어오면 문제가 생길 것 같아요.

Copy link
Collaborator

@amaran-th amaran-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~~!

@hyeonjerry hyeonjerry closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend 백엔드 관련 이슈 리팩터링 테스트 코드의 검증 값이 변환하지 않고 코드 변경
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

3 participants