-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/#861 network view model 적용 #873
Merged
The head ref may contain hidden characters: "Refactor/#861-NetworkViewModel_\uC801\uC6A9"
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- highlightComment 메서드 위치를 사용되는 곳 아래로 옮김
ki960213
added
Android
안드로이드 관련 이슈
리팩터링
테스트 코드의 검증 값이 변환하지 않고 코드 변경
기능 추가
새로운 기능 추가 및 기존 기능 변경
High Priority
리뷰 우선순위가 높은 PR
labels
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Android
안드로이드 관련 이슈
High Priority
리뷰 우선순위가 높은 PR
기능 추가
새로운 기능 추가 및 기존 기능 변경
리팩터링
테스트 코드의 검증 값이 변환하지 않고 코드 변경
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
변경된 기능
공통:
FeedDetail:
FeedWriting:
MessageList:
MyCommentList:
NotificationConfig:
NotificationList:
NotificationTag:
Onboarding:
RecruitmentWriting:
Splash:
KerdyFirebaseMessagingService:
눈에 보이는 큰 변경사항은 위와 같고 세부적인 UI나 코드 형식, 세부적인 로직도 많이 바뀌었습니다. 확인해주세요.
스크린샷 (선택)
예상 소요 시간 및 실제 소요 시간 (일 / 시간 / 분)
예상 소요 시간 : 3일
실제 소요 시간 : 2주
💬 리뷰어 요구사항 (선택)
게시글 작성 화면에서 화면 높이가 작으면 사진에 의해 content EditText가 많이 가려집니다. 이것만 해결해주세요. 😢