도시입력창 & 제안목록 컴포넌트 구현 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleysyheo
requested changes
Jul 15, 2023
There was a problem hiding this comment.
헤다 수고 많았습니다 👍🔥
지금 연결된 이슈 번호가 "trip생성페이지 구현"에 대한 이슈인데, 새로운 이슈를 파거나 이슈 네이밍을 변경해 주면 좋을 것 같아요!
가장 먼저 피그마 시안이랑 만든 컴포넌트랑 많이 다른 것 같아요. 한 번 더 확인부탁드려요. 그리고 컴포넌트를 확인할 방법이 없네요. 스토리북을 추가해주시면 리뷰하는데 도움이 될 것 같아요~
추가적으로 코멘트들도 추가해주면 좋을 것 같아요. 지금 바로 이게 무엇을 위한 로직인지 알기 어려운 부분도 없지 않아 있어요.
일단, 컴포넌트를 바로 확인 할 수 없는 관계로 코드 컨벤션 관련 코멘트들을 주로 남겼습니다!
미완기능
- 제안목록 스크롤바있을 때 키보드 동작 시 자동 스크롤링
- tag 있을 때 입력창 width 줄이기
미완 기능에대해 더 자세히 설명해줄 수 있나요?
| MenuList as SuggestionList, | ||
| MenuItem as SuggestionsItem, | ||
| Text, | ||
| } from 'hang-log-design-system'; |
There was a problem hiding this comment.
이름을 다르게 임포트한 이유가 있나요?
There was a problem hiding this comment.
사용하는 측에서 좀 명확하면 좋을 것 같아서요! 어떠신가유
|
너무 멋져요 |
frontend/src/components/common/CitySuggestion/CitySuggestion.tsx
Outdated
Show resolved
Hide resolved
dladncks1217
approved these changes
Jul 18, 2023
ashleysyheo
approved these changes
Jul 18, 2023
frontend/.storybook/main.ts
Outdated
|
|
||
| config.module?.rules?.push({ | ||
| test: /\.png$/i, | ||
| issuer: /\.[jt]sx?$/, |
| } | ||
|
|
||
| const CitySearchBar = ({ initialCityTags }: CitySearchBarProps) => { | ||
| const [queryWord, setQueryWord] = useState(''); |
There was a problem hiding this comment.
query가 문자라는 의미를 담고 있는 것 같아서 (느낌적인 느낌??) 그래서 word를 안 붙여도 괜찮을 것 같은데, 어떻게 생각하세요!?
frontend/src/mocks/handlers/index.ts
Outdated
| ); | ||
| }), | ||
| ]; | ||
| export const handlers = [...cityHandlers]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
기능
미완기능
🙋🏻 More